This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
Provide a strong boost for upper case matches. #9626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change feels more satisfying for #3263. Also removes no longer used case match.
|
@JeffryBooher let me know what you think... |
|
@dangoor looks like it covers all the cases. All Tests pass and my random tests pass as well. Merging. |
JeffryBooher
added a commit
that referenced
this pull request
Oct 22, 2014
Provide a strong boost for upper case matches.
|
Thanks, Jeff! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change feels more satisfying for #3263.
This simplifies the code by removing the "CaseMatch" and just providing a boost for upper case.
functionvs.Functionbecause of how the prefix match logic works. I'm not sure if there are cases for the full string match logic where we'd prefer case matching even for lower case, but in my random testing (plus the results of the automated tests), I'm happy with how this works...